[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [bug#47615] [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-l
From: |
Maxime Devos |
Subject: |
Re: [bug#47615] [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux. |
Date: |
Thu, 22 Apr 2021 18:41:24 +0200 |
User-agent: |
Evolution 3.34.2 |
Efraim Flashner schreef op do 22-04-2021 om 10:59 [+0300]:
> * gnu/packages/version-control.scm (mercurial)[arguments]: Skip tests on
> powerpc-linux.
> ---
> gnu/packages/version-control.scm | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Unchanged since last patchset, IMO not ready for upstreaming.
>
> diff --git a/gnu/packages/version-control.scm
> b/gnu/packages/version-control.scm
> index 4d4b276a10..13e2ccd400 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -1688,7 +1688,11 @@ execution of any hook written in any language before
> every commit.")
> "--slowtimeout" "86400"
> ;; The test suite takes a long time and produces
> little
> ;; output by default. Prevent timeouts due to
> silence.
> - "-v"))))))))
> + "-v"))))))
> + ;; Tests on powerpc-linux take more than 10 hours.
> + #:tests? ,(if (string=? "powerpc-linux" (or (%current-system)
> + (%current-target-system)))
> + '#f '#t)))
You can remove ' in '#f and '#t here.
That shouldn't cause a derivation change.
Keeping ' is harmless though, it's just superfluous.
Likewise for some other commits.
I'm not really familiar with powerpc and the packages you modified,
so I'm just looking at style, and cross-compilation issues (which you seem
to have covered).
Greetings,
Maxime.
signature.asc
Description: This is a digitally signed message part
- [PATCH v2 00/12] Add 32-bit powerpc support, (continued)
- [PATCH v2 00/12] Add 32-bit powerpc support, Efraim Flashner, 2021/04/22
- [PATCH v2 01/12] gnu: bootstrap: Add support for powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 02/12] gnu: guile-3.0: Fix building on powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 03/12] gnu: gcc-boot0: Use 128-bit long-double on powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 04/12] gnu: binutils: Fix bug in test suite in libiberty., Efraim Flashner, 2021/04/22
- [PATCH v2 05/12] gnu: mesa: Add support for powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 06/12] gnu: Add mac-fdisk., Efraim Flashner, 2021/04/22
- [PATCH v2 07/12] gnu: american-fuzzy-lop: Add support for powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 08/12] build: qemu-command: Add support for powerpc., Efraim Flashner, 2021/04/22
- [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux., Efraim Flashner, 2021/04/22
- Re: [bug#47615] [PATCH v2 09/12] gnu: mercurial: Skip tests on powerpc-linux.,
Maxime Devos <=
- [PATCH v2 10/12] gnu: nss: Skip tests on powerpc-linux., Efraim Flashner, 2021/04/22
- [PATCH v2 11/12] gnu: zstd: Adjust test suite for 32-bit architectures., Efraim Flashner, 2021/04/22
- [PATCH v2 12/12] gnu: glib: Disable failing test., Efraim Flashner, 2021/04/22