[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: A "cosmetic changes" commit that removes security fixes
From: |
Léo Le Bouter |
Subject: |
Re: A "cosmetic changes" commit that removes security fixes |
Date: |
Mon, 26 Apr 2021 16:59:49 +0200 |
User-agent: |
Evolution 3.34.2 |
On Sat, 2021-04-24 at 03:46 -0400, Mark H Weaver wrote:
> Hi Léo,
>
> Léo Le Bouter <lle-bout@zaclys.net> writes:
>
> > On Fri, 2021-04-23 at 15:18 -0400, Leo Famulari wrote:
> > > Léo and Raghav, you need to keep learning our workflow around
> > > security updates. It's not okay to remove security patches and
> > > later
> > > update a package to a fixed version in a different commit. `git
> > > rebase` is the tool to learn for cases like this one.
> >
> > I knew about this but I didnt feel like telling Raghav to do yet
> > another rebase. I felt like Raghav was taking on with so much
> > already.
>
> This response is what native English speakers call a "red herring"
> <https://en.wikipedia.org/wiki/Red_herring>;: something that misleads
> or
> distracts from a relevant or important question.
>
> Why do I say that? As I pointed out elsewhere in this thread,
>
> https://lists.gnu.org/archive/html/guix-devel/2021-04/msg00366.html
>
> it appears that Raghav didn't actually remove the security fixes; it
> appears that *you* did. Therefore, I fail to see how it could have
> been
> avoided by asking Raghav to do another rebase.
>
> From the IRC logs cited in the message above, it appears that you
> took
> the liberty of modifying Raghav's "cosmetic changes" commits to also
> remove security fixes in the re-indented packages, while claiming in
> the
> summary lines that you were "ungraft[ing]" cairo and glib.
>
>
> https://git.sr.ht/~lle-bout/guix/commit/a045a48dd961f0c5c3d536dcc3fd21d9c08d2d50
>
> https://git.sr.ht/~lle-bout/guix/commit/6477daa338fbf1c9edacfc3690aca77cacfe0008
>
> Can you please explain what went wrong here?
>
> Thanks,
> Mark
>
Hello Mark,
I will not answer anything to you anymore because I feel like you do
not write messages in a constructive way.
Léo
signature.asc
Description: This is a digitally signed message part
- Re: A "cosmetic changes" commit that removes security fixes, (continued)
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Leo Prikler, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/23
- Re: A "cosmetic changes" commit that removes security fixes, Giovanni Biscuolo, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Giovanni Biscuolo, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Leo Famulari, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Mark H Weaver, 2021/04/24
- Re: A "cosmetic changes" commit that removes security fixes,
Léo Le Bouter <=
- Re: A "cosmetic changes" commit that removes security fixes, Tobias Geerinckx-Rice, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Ludovic Courtès, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Pjotr Prins, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/26
- Re: A "cosmetic changes" commit that removes security fixes, Marius Bakke, 2021/04/28
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/29
- Re: A "cosmetic changes" commit that removes security fixes, Leo Prikler, 2021/04/29
- Re: A "cosmetic changes" commit that removes security fixes, Léo Le Bouter, 2021/04/29
- Re: A "cosmetic changes" commit that removes security fixes, Arun Isaac, 2021/04/29
- Re: A "cosmetic changes" commit that removes security fixes, Pierre Neidhardt, 2021/04/29