Re: Golang check phase skipping some tests?

[Troy Figiel]

Hi Oleg,

Small update to give you some numbers. Looking through gnu/packages/ I
found a total of 593 packages using the go-build-system. With guix
refresh -l, I find 1449 dependent packages. I am currently at commit
bed3a0b547a59f63b545db165e76ddd9af8bba1a. Take this as a rough estimate,
since I searched back for "define-public" for every occurrence of
"build-system go-build-system".

Without the proposed change in the check phase only a single package
fails to build for me (chezmoi, using x86_64-linux). With the change
this number goes up to 214.

Quite a few failures can be solved by adding missing inputs, but there
is still a fair amount of failures that is harder to solve (cyclic
dependencies, unclear test failures).

All in all, as to be expected I would say. A go-team branch as mentioned
in the other email chain, would be very helpful. In the meantime I will
see how far I get solving some of the build failures locally and sending
those patches to guix-patches.

Best wishes,

Troy

On 2024-01-18 22:45, Sharlatan Hellseher wrote:
> Hi,
> 
> There are not too many Golang packages in Guix comparing to other
> language spectific modules:
> 
> --8<---------------cut here---------------start------------->8---
> grep -r "build-system go-build-system" gnu/packages | awk '{print $1}'
> | sort | uniq -c | sort -rn
>     382 gnu/packages/golang.scm:
>      47 gnu/packages/golang-web.scm:
>      34 gnu/packages/syncthing.scm:
>      17 gnu/packages/golang-check.scm:
>       9 gnu/packages/web.scm:
>       8 gnu/packages/version-control.scm:
>       7 gnu/packages/databases.scm:
>       5 gnu/packages/ipfs.scm:
>       5 gnu/packages/bioinformatics.scm:
>       4 gnu/packages/virtualization.scm:
>       4 gnu/packages/networking.scm:
>       4 gnu/packages/mail.scm:
>       4 gnu/packages/games.scm:
>       4 gnu/packages/docker.scm:
>       4 gnu/packages/check.scm:
>       3 gnu/packages/file-systems.scm:
>       3 gnu/packages/admin.scm:
>       2 gnu/packages/time.scm:
>       2 gnu/packages/textutils.scm:
>       2 gnu/packages/terminals.scm:
>       2 gnu/packages/password-utils.scm:
>       2 gnu/packages/messaging.scm:
>       2 gnu/packages/irc.scm:
>       2 gnu/packages/geo.scm:
>       2 gnu/packages/education.scm:
>       2 gnu/packages/curl.scm:
>       2 gnu/packages/containers.scm:
>       2 gnu/packages/backup.scm:
>       1 gnu/packages/xdisorg.scm:
>       1 gnu/packages/web-browsers.scm:
>       1 gnu/packages/weather.scm:
>       1 gnu/packages/vpn.scm:
>       1 gnu/packages/tls.scm:
>       1 gnu/packages/terraform.scm:
>       1 gnu/packages/tcl.scm:
>       1 gnu/packages/task-runners.scm:
>       1 gnu/packages/task-management.scm:
>       1 gnu/packages/sync.scm:
>       1 gnu/packages/shellutils.scm:
>       1 gnu/packages/radio.scm:
>       1 gnu/packages/pulseaudio.scm:
>       1 gnu/packages/music.scm:
>       1 gnu/packages/monitoring.scm:
>       1 gnu/packages/linux.scm:
>       1 gnu/packages/image-viewers.scm:
>       1 gnu/packages/hyperledger.scm:
>       1 gnu/packages/high-availability.scm:
>       1 gnu/packages/finance.scm:
>       1 gnu/packages/disk.scm:
>       1 gnu/packages/debug.scm:
>       1 gnu/packages/crypto.scm:
>       1 gnu/packages/configuration-management.scm:
>       1 gnu/packages/compression.scm:
>       1 gnu/packages/calendar.scm:
>       1 gnu/packages/authentication.scm:
>       1 gnu/packages/android.scm:
> --8<---------------cut here---------------start------------->8---
> 
> We may enable it globally and rebuild each package and pack and place missing 
> in
> native inputs/propagated inputs depending on the purpose.
> 
> I would love to investigate the count of packages in  `34
> gnu/packages/syncthing.scm:` :-)
> 
> Thanks,
> Oleg
>

OpenPGP_0xC67C9181B3893FB0.asc
Description: OpenPGP public key

OpenPGP_signature.asc
Description: OpenPGP digital signature