guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#25733: [PATCH 12/18] gnu: Add python-docutils-0.11.


From: Ricardo Wurmus
Subject: bug#25733: [PATCH 12/18] gnu: Add python-docutils-0.11.
Date: Sat, 18 Feb 2017 13:21:54 +0100
User-agent: mu4e 0.9.18; emacs 25.1.1

address@hidden writes:

> From: ng0 <address@hidden>
>
> * gnu/packages/python.scm (python-docutils-0.11): New variable.
> ---

[…]

> +;; kallithea-0.3.2 needs this

I wonder: does Kallithea *really* need these particular versions or does
it just have overly strict version checks?

> +(define-public python-docutils-0.11
> +  (package
> +    (inherit python-docutils)
> +    (version "0.11")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "docutils" version))
> +       (sha256
> +        (base32
> +         "1jbybs5a396nrjy9m13pgvsxdwaj7jw7nsawkhl4fi1nvxm1dx4s"))))))

Okay.

> +(define-public python2-docutils-0.11
> +  (package-with-python2 python-docutils-0.11))
> +

Much better!  But: I’d rather not add the Python 2 variant unless it’s
really needed.  If Kallithea really just needs the Python 2 variant,
then please do not add the Python 3 variant.  The same comment applies
to all other patches in this series that add variants like this.

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net






reply via email to

[Prev in Thread] Current Thread [Next in Thread]