bug#26173: [PATCH 3/4] tests: ssh: Abstract session connection and authentication.

[Clément Lassieur]

Ludovic Courtès <address@hidden> writes:

> Clément Lassieur <address@hidden> skribis:
>
>> * gnu/tests/ssh.scm (run-ssh-test): Introduce make-session-for-test,
>> call-with-connected-session and call-with-connected-session/auth.
>> (run-ssh-test)["connect"]: Rename to "shell command".  Abstract its session
>> connection and authentication work into the above three functions.
>
> It looks nicer with this change, cool!
>
>> -                (match (connect! session)
>> -                  ('ok
>> -                   ;; Try the simple authentication methods.  Dropbear
>> -                   ;; requires 'none' when there are no passwords, whereas
>> -                   ;; OpenSSH accepts 'password' with an empty password.
>> -                   (let loop ((methods (list (cut userauth-password! <> "")
>> -                                             (cut userauth-none! <>))))
>
> This comment vanished in the refactoring but it might be worth keeping.

Oh!  Sorry, that wasn't intentional.

> Otherwise LGTM, thanks!
>
> Ludo’.