[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26213: [PATCH] maint: Mention the Signed-off-by line in 'HACKING'.
From: |
Clément Lassieur |
Subject: |
bug#26213: [PATCH] maint: Mention the Signed-off-by line in 'HACKING'. |
Date: |
Fri, 24 Mar 2017 13:58:42 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Marius Bakke <address@hidden> writes:
> Clément Lassieur <address@hidden> writes:
>
>> * HACKING: Mention the Signed-off-by line.
>> ---
>> HACKING | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/HACKING b/HACKING
>> index 46a724961..26f828bd6 100644
>> --- a/HACKING
>> +++ b/HACKING
>> @@ -50,6 +50,10 @@ You can prevent yourself from accidentally pushing
>> unsigned commits to Savannah
>> by using the pre-push Git hook called 'pre-push'. It's located at
>> 'etc/git/pre-push'.
>>
>> +When pushing a commit on behalf of somebody else, you should add a
>> +Signed-off-by line at the end of the commit log message (e.g. with ‘git am
>> +--signoff’). This improves tracking of who did what.
>
> s/you should/please. Otherwise LGTM.
Thank you for reviewing! Pushed.
>> For anything else, please post to address@hidden and leave time for a
>> review, without committing anything. If you didn’t receive any reply
>> after two weeks, and if you’re confident, it’s OK to commit.
>> --
>> 2.12.0