bug#26391: [PATCH 0/1] Patching getcap and which in torsocks

[ng0]

Eric Bavier transcribed 0.8K bytes:
> This patches references to the 'getcap' and 'which' programs in 'torsocks'
> so that users that don't have either of those packages installed in their
> profiles do not see confusing output about them missing.  Usually torsocks
> will still function in that case, but it's probably better to have them
> available.
> 
> I've so far done this sort of thing for several packages with shell scripts,
> and each time I'm convinced that this method is better than declaring the
> inputs in propagated-inputs.  But I think I'd feel more sure of myself if we
> had a short "Packaging shell scripts" section in the manual that outlined
> best-practices-of-the-moment.  Would that be useful?
> 
> Eric Bavier (1):
>   gnu: torsocks: Patch references to 'getcap' and 'which'.
> 
>  gnu/packages/tor.scm | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> -- 
> 2.12.2
> 
> 

I have not run the patch, but the code looks good to me.
The "dependencies" are not obvious, so your proposed change is okay.