[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26488: [PATCH] gnu: Add crawl.
From: |
Arun Isaac |
Subject: |
bug#26488: [PATCH] gnu: Add crawl. |
Date: |
Wed, 19 Apr 2017 11:41:34 +0530 |
> Thank you very much, for your intensive help with cleaning up this package!
No problem! That's what I'm here for... :-) And, thank you for your
patience with all my corrections!
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (delete 'check)
> + ;; Test cases require the source to be rebuild with the -DDEBUG
> define.
> + ;; Do 'check before 'build to avoid a 3rd build on make install.
> + (add-before 'build 'check
> + (lambda* (#:key inputs outputs make-flags
> + parallel-build? parallel-tests? #:allow-other-keys)
Since you are not using the parallel-build? and parallel-tests? keyword
arguments anymore, why keep them in the argument list?
> + (zero? (apply system* "make" "debug" "test"
> + (cons (format #f "-j~d" (parallel-job-count))
> + make-flags))))))))
As noted earlier, only the last argument of apply needs to be a
list. So, this can be shortened to something like:
(zero? (apply system* "make" (format #f "-j~d"
(parallel-job-count)) "debug" "test" make-flags))
Everything else LGTM! Only the graphical build remains now.
- bug#26488: [PATCH] gnu: Add crawl., nee, 2017/04/13
- Message not available
- bug#26488: [PATCH] gnu: Add crawl., Arun Isaac, 2017/04/14
- bug#26488: [PATCH] gnu: Add crawl., nee, 2017/04/14
- bug#26488: [PATCH] gnu: Add crawl., Danny Milosavljevic, 2017/04/14
- bug#26488: [PATCH] gnu: Add crawl., Arun Isaac, 2017/04/14
- Message not available
- bug#26488: [PATCH] gnu: Add crawl., nee, 2017/04/16
- bug#26488: [PATCH] gnu: Add crawl., Arun Isaac, 2017/04/17
- bug#26488: [PATCH] gnu: Add crawl., nee, 2017/04/18
- bug#26488: [PATCH] gnu: Add crawl.,
Arun Isaac <=
- bug#26488: [PATCH] gnu: Add crawl., Christopher Allan Webber, 2017/04/21
- bug#26488: [PATCH] gnu: Add crawl., Arun Isaac, 2017/04/21
- bug#26488: [PATCH] gnu: Add crawl., Arun Isaac, 2017/04/17
- bug#26488: [PATCH] gnu: Add crawl., nee, 2017/04/17