guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#26339: [PATCH v2 10/12] scripts: system: Adapt "init" to new bootloa


From: Mathieu Othacehe
Subject: bug#26339: [PATCH v2 10/12] scripts: system: Adapt "init" to new bootloader API.
Date: Sun, 23 Apr 2017 18:34:25 +0200
User-agent: mu4e 0.9.18; emacs 25.2.1

> "installer" instead of "install-proc" ?

Ok for "installer".

>> +      (maybe-copy
>> +       (derivation->output-path bootcfg))
>
> Does derivation->output-path change anything?

Well I guess yes, because maybe-copy is expecting a path and not a
derivation.

>
>>+                      #:bootloader? bootloader?
>
> What about the bootloader? :)
>
> "install-bootloader?" ?

Ok for install-bootloader? :)

>
>>+                      #:install-proc
>
> #:bootloader-installer ?

Seems ok to me.

>
> Otherwise LGTM!

Thanks, I'll publish a rebased version, maybe when your own bootloader
serie will be pushed !

Mathieu






reply via email to

[Prev in Thread] Current Thread [Next in Thread]