[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26684: let nginx configs reference the store
From: |
Clément Lassieur |
Subject: |
bug#26684: let nginx configs reference the store |
Date: |
Thu, 04 May 2017 00:58:34 +0200 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Andy Wingo <address@hidden> writes:
> Hi,
>
> Is this the right way to do things? Passing lists around seems to be an
> intermediate point between strings and proper configuration values -- as
> such it seems like a useful intermediate step. The context is that I
> need to be able to extend the nginx configuration with a server config
> that references a store path.
>
> Andy
>
> From b56b797e2ca26619485d874110d3f1f0ae96fba4 Mon Sep 17 00:00:00 2001
> From: Andy Wingo <address@hidden>
> Date: Thu, 27 Apr 2017 19:49:02 +0200
> Subject: [PATCH 1/5] gnu: services: Nginx configs can reference store
>
> * gnu/services/web.scm (config-domain-strings, config-index-strings): Emit
> lists instead of strings.
> (emit-nginx-location-config, emit-nginx-server-config)
> (emit-nginx-upstream-config): Rename from nginx-location-config,
> default-nginx-server-config, and nginx-upstream-config. Emit lists instead of
> strings.
> (flatten): New helper.
> (default-nginx-config): Use flatten helper to write nginx conf. This allows
> location configs to reference store values.
> ---
> gnu/services/web.scm | 150
> +++++++++++++++++++++++++--------------------------
> 1 file changed, 74 insertions(+), 76 deletions(-)
Hi Andy,
I tested it successfully (with a reference to the store), and it looks
good to me as well. Thanks you! You'll have some rebasing work to do
though with (lstat ssl-cert...).
Clément