[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#26803: [PATCH 16/36] gnu: Add java-commons-lang.
From: |
Roel Janssen |
Subject: |
bug#26803: [PATCH 16/36] gnu: Add java-commons-lang. |
Date: |
Mon, 08 May 2017 12:46:15 +0200 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
Ricardo Wurmus writes:
> From: Hartmut Goebel <address@hidden>
>
> * gnu/packages/java.scm (java-commons-lang): New variable.
>
> Co-authored-by: Ricardo Wurmus <address@hidden>
> ---
> gnu/packages/java.scm | 55
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 55 insertions(+)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index c9707d0d2..7a68b6bd6 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -1665,3 +1665,58 @@ are many features, including:
> (description "Commons-IO contains utility classes, stream
> implementations,
> file filters and endian classes.")
> (license license:asl2.0)))
> +
> +(define-public java-commons-lang
> + (package
> + (name "java-commons-lang")
> + (version "2.6")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (string-append "mirror://apache/commons/lang/source/"
> + "commons-lang-" version "-src.tar.gz"))
> + (sha256
> + (base32 "1mxwagqadzx1b2al7i0z1v0r235aj2njdyijf02szq0vhmqrfiq5"))))
> + (build-system ant-build-system)
> + (outputs '("out" "doc"))
> + (arguments
> + `(#:test-target "test"
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'build 'build-javadoc ant-build-javadoc)
> + (add-before 'check 'disable-failing-test
> + (lambda _
> + ;; Disable a failing test
> + (substitute* "src/test/java/org/apache/commons/lang/\
> +time/FastDateFormatTest.java"
> + (("public void testFormat\\(\\)")
> + "public void disabled_testFormat()"))
> + #t))
Since you're renaming the function, I suppose removing the function
would also work, which would not create any "dead code". But that
probably requires a separate patch file, which will break more easily
on an update.
So long story short: This is OK to me, even though I don't like
producing code that won't be run anyway.
> + (replace 'install (install-jars "target"))
> + (add-after 'install 'install-doc (install-javadoc
> "target/apidocs")))))
> + (native-inputs
> + `(("java-junit" ,java-junit)))
> + (home-page "http://commons.apache.org/lang/")
> + (synopsis "Extension of the java.lang package")
> + (description "The Commons Lang components contains a set of Java classes
> +that provide helper methods for standard Java classes, especially those found
> +in the @code{java.lang} package in the Sun JDK. The following classes are
> +included:
> +
> address@hidden
> address@hidden StringUtils - Helper for @code{java.lang.String}.
> address@hidden CharSetUtils - Methods for dealing with @code{CharSets}, which
> are sets
> + of characters such as @code{[a-z]} and @code{[abcdez]}.
> address@hidden RandomStringUtils - Helper for creating randomised strings.
> address@hidden NumberUtils - Helper for @code{java.lang.Number} and its
> subclasses.
> address@hidden NumberRange - A range of numbers with an upper and lower bound.
> address@hidden ObjectUtils - Helper for @code{java.lang.Object}.
> address@hidden SerializationUtils - Helper for serializing objects.
> address@hidden SystemUtils - Utility class defining the Java system
> properties.
> address@hidden NestedException package - A sub-package for the creation of
> nested
> + exceptions.
> address@hidden Enum package - A sub-package for the creation of enumerated
> types.
> address@hidden Builder package - A sub-package for the creation of
> @code{equals},
> + @code{hashCode}, @code{compareTo} and @code{toString} methods.
> address@hidden itemize\n")
> + (license license:asl2.0)))
I've seen the '\n' on an earlier patch as well. Why is it neccessary?
Otherwise, LGTM!
Kind regards,
Roel Janssen
- bug#26803: [PATCH 15/36] gnu: Add java-commons-io., (continued)
bug#26803: [PATCH 12/36] gnu: Add java-commons-math3., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 19/36] gnu: Add java-commons-codec., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 16/36] gnu: Add java-commons-lang., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 18/36] gnu: Add java-commons-cli., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 17/36] gnu: Add java-commons-lang3., Ricardo Wurmus, 2017/05/06
bug#26803: [PATCH 22/36] gnu: java-hamcrest-core: Declare test target., Ricardo Wurmus, 2017/05/06