|
From: | Clément Lassieur |
Subject: | bug#27073: [PATCH] gnu: Add cpuid. |
Date: | Thu, 25 May 2017 21:41:00 +0200 |
User-agent: | mu4e 0.9.18; emacs 25.2.1 |
Marius Bakke <address@hidden> writes: > Clément Lassieur <address@hidden> writes: > >> * gnu/packages/linux.scm (cpuid): New variable. > > [...] > >> + #:phases (modify-phases %standard-phases >> + (delete 'configure) >> + (add-before 'install 'fix-makefile >> + (lambda* (#:key outputs #:allow-other-keys) >> + (substitute* "Makefile" >> + (("\\$\\(BUILDROOT\\)/usr") (assoc-ref outputs >> "out"))) >> + (substitute* "Makefile" >> + (("-m 444") "-m 644")) > > Why is this necessary? Perhaps you can add a comment? I added: ;; Make the compressed manpages writable so that the ;; reset-gzip-timestamps phase does not error out. > LGTM otherwise. Thanks for the review :-) Pushed.
[Prev in Thread] | Current Thread | [Next in Thread] |