[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27075: [PATCH] gnu: Add multitail
From: |
Stefan Reichör |
Subject: |
bug#27075: [PATCH] gnu: Add multitail |
Date: |
Thu, 25 May 2017 23:35:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marius Bakke <address@hidden> writes:
Thanks for your review!
> Stefan Reichör <address@hidden> writes:
>
>> Hi there,
>>
>> I am not sure what category fits best for multitail. I have added it to
>> less as a first attempt.
>
> Thanks for this! I think "logging.scm" works well for this package. A
> few comments:
o.k.
>> + #:phases
>> + (modify-phases %standard-phases
>> + (add-after 'unpack 'patch-curses-lib
>> + (lambda* (#:key outputs #:allow-other-keys)
>> + (let ((out (assoc-ref outputs "out")))
>> + (substitute* "mt.h"
>> + (("ncursesw\\/panel.h") "panel.h")
>> + (("ncursesw\\/ncurses.h") "ncurses.h")))
>> + #t))
>> + (delete 'configure)
>> + (delete 'check)))) ; no test suite (make check just runs cppcheck)
>
> Instead of deleting the 'check' phase, you can set the #:tests? keyword
> to #f.
>
>> + (inputs `(("ncurses" ,ncurses)))
>> + (home-page "https://vanheusden.com/multitail/")
>> + (synopsis "Monitor multiple logfiles")
>> + (description
>> + "MultiTail allows you to monitor logfiles and command output in
>> multiple
>> +windows in a terminal, colorize, filter and merge.")
>> + (license gpl2)))
>
> When there is no version information indicated in the source code
> headers, we default to "or later" (i.e. gpl2+ in this instance).
I read the LICENSE file
(https://github.com/flok99/multitail/blob/master/LICENSE) and thought it is
gpl2.
But I updated it to gpl2+ now.
>
> The rest LGTM. Can you send an updated patch?
Here is the updated patch:
>From 7e98231dbe260b4345fe182cf320aa2bb1f060dd Mon Sep 17 00:00:00 2001
From: Stefan Reichoer <address@hidden>
Date: Thu, 25 May 2017 23:34:02 +0200
Subject: [PATCH] gnu: Add multitail.
* gnu/packages/logging.scm (multitail): New variable.
---
gnu/packages/logging.scm | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index b2b0582..eecfe45 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -1,6 +1,7 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2016 Ricardo Wurmus <address@hidden>
;;; Copyright © 2016, 2017 Ludovic Courtès <address@hidden>
+;;; Copyright © 2017 Stefan Reichör <address@hidden>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -26,6 +27,7 @@
#:use-module (guix build-system gnu)
#:use-module (guix build-system python)
#:use-module (gnu packages)
+ #:use-module (gnu packages ncurses)
#:use-module (gnu packages perl)
#:use-module (gnu packages python)
#:use-module (gnu packages autotools))
@@ -129,3 +131,41 @@ command line.")
"Tailon provides a web interface around the tail, grep, awk and sed
commands, displaying the results via a web interface.")
(license license:bsd-3)))
+
+(define-public multitail
+ (package
+ (name "multitail")
+ (version "6.4.2")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (string-append "https://vanheusden.com/multitail/multitail-"
+ version ".tgz"))
+ (sha256
+ (base32
+ "1zd1r89xkxngl1pdrvsc877838nwkfqkbcgfqm3vglwalxc587dg"))))
+ (build-system gnu-build-system)
+ (arguments
+ `(#:make-flags
+ (list "CC=gcc"
+ "PREFIX="
+ (string-append "DESTDIR="
+ (assoc-ref %outputs "out")))
+ #:phases
+ (modify-phases %standard-phases
+ (add-after 'unpack 'patch-curses-lib
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (substitute* "mt.h"
+ (("ncursesw\\/panel.h") "panel.h")
+ (("ncursesw\\/ncurses.h") "ncurses.h")))
+ #t))
+ (delete 'configure))
+ #:tests? #f)) ; no test suite (make check just runs cppcheck)
+ (inputs `(("ncurses" ,ncurses)))
+ (home-page "https://vanheusden.com/multitail/")
+ (synopsis "Monitor multiple logfiles")
+ (description
+ "MultiTail allows you to monitor logfiles and command output in multiple
+windows in a terminal, colorize, filter and merge.")
+ (license license:gpl2+)))
--
2.7.4