[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#27173: [PATCH] import: pypi: Always use pypi.io URL with downcased p
From: |
Ludovic Courtès |
Subject: |
bug#27173: [PATCH] import: pypi: Always use pypi.io URL with downcased package name. |
Date: |
Thu, 01 Jun 2017 14:14:18 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
address@hidden (Ludovic Courtès) skribis:
> Hi Danny,
>
> Danny Milosavljevic <address@hidden> skribis:
>
>> * guix/import/pypi.scm (make-pypi-sexp): Always use pypi.io URL with
>> downcased package name.
>> ---
>> guix/import/pypi.scm | 6 +-----
>> 1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/guix/import/pypi.scm b/guix/import/pypi.scm
>> index 9c72e7331..90dbe5612 100644
>> --- a/guix/import/pypi.scm
>> +++ b/guix/import/pypi.scm
>> @@ -258,11 +258,7 @@ VERSION, SOURCE-URL, HOME-PAGE, SYNOPSIS, DESCRIPTION,
>> and LICENSE."
>> ;; Sometimes 'pypi-uri' doesn't quite work due to
>> mixed
>> ;; cases in NAME, for instance, as is the case with
>> ;; "uwsgi". In that case, fall back to a full URL.
>> - (uri ,(if (equal? (pypi-uri name version) source-url)
>> - `(pypi-uri ,name version)
>> - `(string-append
>> - ,@(factorize-uri source-url version))))
>> -
>> + (uri (pypi-uri ,(string-downcase name) version))
>
> So is the command above outdated?
^------
Should read: “the comment.”
Ludo’.