[bug#25728] [PATCH 2/2] gnu: Add colorforth.

[ng0]

Ricardo Wurmus transcribed 2.5K bytes:
> 
> ng0 <address@hidden> writes:
> 
> > Version two of the patches attached.
> > --
> […]
> 
> >>From 9c0221c7558b6d87124563fdc4fdde5c32a0374d Mon Sep 17 00:00:00 2001
> > From: ng0 <address@hidden>
> > Date: Thu, 6 Oct 2016 22:31:46 +0000
> > Subject: [PATCH 2/2] gnu: Add colorforth.
> >
> > * gnu/packages/forth.scm (colorforth): New variable.
> > ---
> […]
> > +
> > +(define-public colorforth
> > +  (let ((commit "94aec438f1ded202681f18801b98c52dc3beee41")
> > +        (revision "1"))
> > +    (package
> > +      (name "colorforth")
> > +      (version (string-append "0.0.0-" revision "." (string-take commit 
> > 7)))
> > +      (source (origin
> > +                (method git-fetch)
> > +                (uri (git-reference
> > +                      (url "https://github.com/narke/colorForth";)
> > +                      (commit commit)))
> > +                (sha256
> > +                 (base32
> > +                  
> > "0s602k568bm6vmvpahsms77liicg38vksn59j5m8ax4h9l9ca77r"))))
> > +      (arguments
> > +       `(#:tests? #f
> 
> There should be a comment to explain why tests are disabled.
> 
> > +         #:phases
> > +         (modify-phases %standard-phases
> > +           (delete 'configure) ;No configure script
> > +           (replace 'install ;No install target
> > +             (lambda* (#:key outputs #:allow-other-keys)
> > +               (install-file "cf2012.img"
> > +                             (string-append (assoc-ref outputs "out")
> > +                                            "/bin"))
> > +               #t)))))
> 
> If I understood this correctly, this is not an executable.  One is
> supposed to run this with qemu.  This means that it doesn’t belong in
> “bin”.

Could you propose a directory? I would pick 'share/colorforth/'.

> > +      (native-inputs
> > +       `(("nasm" ,nasm)))
> > +      (build-system gnu-build-system)
> > +      (home-page "https://github.com/narke/colorForth";)
> > +      (synopsis "Native 32-bit colorForth for PCs, Bochs and Qemu")
> > +      (description
> > +       "Colorforth is a @code{colorForth} implementation written in
> > +x86 assembly.  It is a dialect of Forth that uses color to replace
> > +punctation, includes its own operating system and produces extremely
> > +compact programs.  Applications compile from pre-parsed source.
> > +Colorforth applications can be run using @code{Bochs} and @code{Qemu}.
> > +It is adapted from @url{http://sourceforge.net/projects/colorforth,
> > +colorforth}.")
> > +      (license license:public-domain))))
> 
> I could not find a license statement anywhere in the repository.  How do
> you know it’s public domain software?

I think I assumed by the software it was based on.
Great, one of these github-style software productions.
Thanks, I'll ask the author to include a statement.

> --
> Ricardo
> 
> GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
> https://elephly.net
> 

-- 
ng0
OpenPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
https://krosos.org/~/ng0/ https://www.infotropique.org

signature.asc
Description: PGP signature