[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#27643] [PATCH] gnu: Add simplescreenrecorder.
From: |
Alex Vong |
Subject: |
[bug#27643] [PATCH] gnu: Add simplescreenrecorder. |
Date: |
Tue, 11 Jul 2017 21:34:22 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Arun Isaac <address@hidden> writes:
> Thanks for the patch!
>
>> + (inputs `(("pkg-config" ,pkg-config)
>
> pkg-config should be a native input.
>
I forget to run lint before submitting the patch... I have fixed this
issue and other formatting issues reported by lint.
>> + ("qt" ,qt-4) ; README.md: using Qt 5 causes some stability issues
>> + ("ffmpeg" ,ffmpeg)
>> + ("alsa-lib" ,alsa-lib)
>> + ("pulseaudio" ,pulseaudio)
>> + ("jack" ,jack-1)
>> + ("glu" ,glu)
>> + ("libx11" ,libx11)
>> + ("libxfixes" ,libxfixes)
>> + ("libxext" ,libxext)
>
> The package builds successfully without libx11, libxfixes and libxext
> included as inputs. Are you sure they are needed? Could you check again?
>
>> + ("libxi" ,libxi)))
>
These packages are listed as Build dependencies in README[0]. What do
you think?
> Also, could you sort all the inputs in alphabetical order, just for the
> aesthetic appeal? :-)
>
>> + ;; Using HTTPS causes part of the page displayed improperly.
>> + (home-page "http://www.maartenbaert.be/simplescreenrecorder/")
>
> We'll go with the HTTP URL for now. But, do report this issue upstream
> as well.
Yeah, I'll report it later.
Thanks for the review!
[0]: https://github.com/MaartenBaert/ssr
signature.asc
Description: PGP signature
bug#27643: [PATCH] gnu: Add simplescreenrecorder., Arun Isaac, 2017/07/12
Message not available