[bug#27671] [PATCH] gnu: Add bmon.

[Tobias Geerinckx-Rice]

Arun,

Thanks! Just a few comments:

On 12/07/17 17:43, Arun Isaac wrote:
> +(define-public bmon
> +  (package
> +    (name "bmon")
> +    (version "4.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append 
> "https://github.com/tgraf/bmon/releases/download/v4.0/bmon-";

Use ‘version’ instead of "4.0" here, as well.

> +                           version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0ylzriv4pwh76344abzl1w219x188gshbycbna35gsyfp09c7z82"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("libconfuse" ,libconfuse)
> +       ("libnl" ,libnl)
> +       ("ncurses" ,ncurses)))
> +    (native-inputs `(("pkg-config" ,pkg-config)))

I'd write this as two lines for consistency and aesthetics.

> +    (synopsis "Bandwidth monitor")
> +    (description "bmon is a monitoring and debugging tool to capture
> +networking related statistics and prepare them visually in a human friendly

‘networking-related’, ‘human-friendly’.

> +way.  It features various output methods including an interactive curses user
> +interface and a programmable text output for scripting.")
> +    (home-page "https://github.com/tgraf/bmon";)
> +    (license (list license:bsd-2
> +                   license:expat))))

Hm. Do you know which files are BSD-licenced? Quite a few have an
expat-style header, but only ‘README.md’ mentions BSD (while saying
nothing of use).

Kind regards,

T G-R

signature.asc
Description: OpenPGP digital signature