[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#27654] [PATCH] base: Report evaluation error.
From: |
Ludovic Courtès |
Subject: |
[bug#27654] [PATCH] base: Report evaluation error. |
Date: |
Wed, 12 Jul 2017 22:54:05 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Mathieu Othacehe <address@hidden> skribis:
> From c9a3325c1c021564edc689ff2421b04c9e794052 Mon Sep 17 00:00:00 2001
> From: Mathieu Othacehe <address@hidden>
> Date: Tue, 11 Jul 2017 19:15:08 +0200
> Subject: [PATCH] base: Report evaluation error.
>
> * src/cuirass/base.scm (evaluate): Report an error if eof-object? is true on
> data read from port. Otherwise, suppose that data are correct and keep thins
> going.
Please mention the new ‘&evaluation-error’ in here.
BTW, shouldn’t ‘process-specs’ protect against it, so that Cuirass
doesn’t stop as soon as it encounters an evaluation error? Like:
diff --git a/src/cuirass/base.scm b/src/cuirass/base.scm
index fc3cc1a..3d19bda 100644
--- a/src/cuirass/base.scm
+++ b/src/cuirass/base.scm
@@ -185,9 +185,12 @@ if required. Return the last commit ID on success, #f
otherwise."
#:use-substitutes? (%use-substitutes?)
#:keep-going? #t)
+ (guard (c ((evaluation-error? c)
+ ;; Report the problem in the log...
+ #f))
(let* ((spec* (acons #:current-commit commit spec))
(jobs (evaluate store db spec*)))
- (build-packages store db jobs))))
+ (build-packages store db jobs)))))
(db-add-stamp db spec commit))))
(for-each process jobspecs))
OK with something along these lines, thanks!
Ludo’.