[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode.
From: |
Arun Isaac |
Subject: |
[bug#27859] [PATCH] gnu: Add emacs-rpm-spec-mode. |
Date: |
Fri, 28 Jul 2017 17:13:38 +0530 |
Thanks for the patch!
> +(define-public emacs-rpm-spec-mode
> + (let ((commit "bbce63f042ea07aa8c2fe67e02357c8521624293")
> + (revision "1"))
> + (package
> + (name "emacs-rpm-spec-mode")
> + (version (string-append "0.0.1-" revision "."
> + (string-take commit 7)))
version should be 0.16. Look at line 7 of rpm-spec-mode.el.
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url (string-append
> + "https://src.fedoraproject.org/git/rpms"
> + "/emacs-rpm-spec-mode.git"))
> + (commit commit)))
> + (file-name (string-append name "-" version "-checkout"))
> + (sha256
> + (base32
> + "0cznnm5jmi38xr8ycnmkcyp60a9nvq9rlhy2w3lij4070n6xzcb4"))))
It would be nice if upstream provided a release tarball. We wouldn't
have to clone their git repo. Could you ask them about it?
> + (build-system emacs-build-system)
> + (home-page (string-append "http://pkgs.fedoraproject.org/cgit/rpms"
> + "/emacs-rpm-spec-mode.git"))
> + (synopsis "Emacs major mode for editing RPM spec files")
> + (description "@code{emacs-rpm-spec-mode} provides Emacs major mode for
> +editing RPM spec files.")
> + (license license:gpl2+))))
LGTM, otherwise!