guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#28327: [PATCH] gnu: Add emacs-bash-completion.


From: Jan Nieuwenhuizen
Subject: bug#28327: [PATCH] gnu: Add emacs-bash-completion.
Date: Sun, 10 Sep 2017 22:45:31 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Alex Kost writes:

>> I have added something here and built package works and looks okay...
>
> Now it looks OK for me as well :-)

Good!

> I see that with your patch, 'bash-completion-prog' has the value
> "/gnu/store/...-bash-4.4.12/bin/bash", so it is definitely 'bash'
> ('bash-minimal' has "/gnu/store/...-bash-minimal-4.4.12/bin/bash" name).

Also good, thanks for checking.

>> I used guix import elpa --archive=melpa and didn't check.  It seems we
>> cannot rely on that!
>
> We definitely shouldn't rely on it, as the importer always puts 'gpl3+':
>
>   http://git.savannah.gnu.org/cgit/guix.git/tree/guix/import/elpa.scm#n234

Great!

> The patch looks good for me, thank you!

Pushed to master as 4aafce22ab74007c69aecc474816d83e64d22646

janneke

-- 
Jan Nieuwenhuizen <address@hidden> | GNU LilyPond http://lilypond.org
Freelance IT http://JoyofSource.com | AvatarĀ® http://AvatarAcademy.com





reply via email to

[Prev in Thread] Current Thread [Next in Thread]