[bug#28579] gpa

[Nicolas Goaziou]

Hello,

ng0 <address@hidden> writes:

> A GUI for GnuPG.
>
> Builds.
> GUI works, Preferences pick up my $HOME/.gnupg settings.
> More wasn't tested.

Thank you. I have some comments about your patch.

> +(define-public gpa
> +  (package
> +    (name "gpa")
> +    (version "0.9.9")

version 0.9.10 is out since 2016. Would it make sense to package it instead?

> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append "ftp://ftp.gnupg.org/gcrypt/gpa/";
> +                          name "-" version ".tar.bz2"))

Guix lint reports:

  URL should be "mirror://gnupg/gpa/gpa-0.9.9.tar.bz2"

> +      (sha256
> +       (base32
> +        "0d235hcqai7m3qb7m9kvr2r4qg4714f87j9fdplwrlz1p4wdfa38"))))
> +    (build-system gnu-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("gnupg" ,gnupg)
> +       ("gpgme" ,gpgme)
> +       ("libassuan" ,libassuan)
> +       ("libgpg-error" ,libgpg-error)
> +       ("gtk+-2" ,gtk+-2)))
> +    (home-page "https://gnupg.org/software/gpa/index.html";)
> +    (synopsis "GUI for GnuPG")
> +    (description
> +     "@defn{GNU Privacy Assistant} (GPA) is a graphical user
> +interface for the @defn{GNU Privacy Guard} (GnuPG).")

Guix lint reports an error about invalid Texinfo markup.

I'm not sure about what to do to fix it, if there is anything to do at
all. IMO, @defn is not adequate here.

> +    (license license:gpl3)))

Every ".c" file I checked use "or any later version". I think this
should be "gpl3+". WDYT?

Regards,

-- 
Nicolas Goaziou                                                0x80A93738