[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29409] [PATCH] build: utils: Introduce dd.
From: |
Mathieu Othacehe |
Subject: |
[bug#29409] [PATCH] build: utils: Introduce dd. |
Date: |
Mon, 04 Dec 2017 16:53:31 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.2.1 |
> I think you can use ‘call-with-output-file’ for DEVICE no?
Sure.
> No: this would import the host Guile’s (ice-9 binary-ports) module into
> the guest, thereby making the result dependent on the Guile version
> being used “outside”.
Ok got it.
> Could you send an updated patch?
You'll find the updated patch attached.
Thanks for your fast review !
Mathieu
>From 143057ead198a75e8a7a2bb1bb706402dcb7d4c3 Mon Sep 17 00:00:00 2001
From: Mathieu Othacehe <address@hidden>
Date: Fri, 1 Dec 2017 14:09:38 +0100
Subject: [PATCH] bootloader: extlinux: Stop using dd binary.
* gnu/bootloader/extlinux.scm (dd): Remove it,
(install-extlinux): replace dd call by Guile I/O procedures.
* gnu/system/vm.scm (qemu-image): Add (ice-9 binary-ports) to used-modules
list to provide "get-bytevector-n" and "put-bytevector".
* guix/scripts/system.scm (bootloader-installer-derivation): Ditto.
---
gnu/bootloader/extlinux.scm | 20 +++++++++-----------
gnu/system/vm.scm | 3 ++-
guix/scripts/system.scm | 3 ++-
3 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/gnu/bootloader/extlinux.scm b/gnu/bootloader/extlinux.scm
index 0db5598..9b6e2c7 100644
--- a/gnu/bootloader/extlinux.scm
+++ b/gnu/bootloader/extlinux.scm
@@ -85,14 +85,6 @@ TIMEOUT ~a~%"
;;; Install procedures.
;;;
-(define dd
- #~(lambda (bs count if of)
- (zero? (system* "dd"
- (string-append "bs=" (number->string bs))
- (string-append "count=" (number->string count))
- (string-append "if=" if)
- (string-append "of=" of)))))
-
(define (install-extlinux mbr)
#~(lambda (bootloader device mount-point)
(let ((extlinux (string-append bootloader "/sbin/extlinux"))
@@ -101,9 +93,15 @@ TIMEOUT ~a~%"
(for-each (lambda (file)
(install-file file install-dir))
(find-files syslinux-dir "\\.c32$"))
-
- (unless (and (zero? (system* extlinux "--install" install-dir))
- (#$dd 440 1 (string-append syslinux-dir "/" #$mbr)
device))
+ (unless
+ (and (zero? (system* extlinux "--install" install-dir))
+ (call-with-input-file (string-append syslinux-dir "/" #$mbr)
+ (lambda (input)
+ (let ((bv (get-bytevector-n input 440)))
+ (call-with-output-file device
+ (lambda (output)
+ (put-bytevector output bv))
+ #:binary #t)))))
(error "failed to install SYSLINUX")))))
(define install-extlinux-mbr
diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm
index b68cce3..d754ac7 100644
--- a/gnu/system/vm.scm
+++ b/gnu/system/vm.scm
@@ -278,7 +278,8 @@ the image."
#~(begin
(use-modules (gnu build vm)
(guix build utils)
- (srfi srfi-26))
+ (srfi srfi-26)
+ (ice-9 binary-ports))
(let ((inputs
'#$(append (list qemu parted e2fsprogs dosfstools)
diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm
index 91d151d..e2ff426 100644
--- a/guix/scripts/system.scm
+++ b/guix/scripts/system.scm
@@ -676,7 +676,8 @@ and TARGET arguments."
(gexp->file "bootloader-installer"
(with-imported-modules '((guix build utils))
#~(begin
- (use-modules (guix build utils))
+ (use-modules (guix build utils)
+ (ice-9 binary-ports))
(#$installer #$bootloader #$device #$target))))))
(define* (perform-action action os
--
2.7.4