guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#29543] [PATCH] gnu: windowmaker: Add '.desktop' file.


From: Kei Kebreau
Subject: [bug#29543] [PATCH] gnu: windowmaker: Add '.desktop' file.
Date: Wed, 06 Dec 2017 14:46:40 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Kei Kebreau <address@hidden> skribis:
>
>> * gnu/packages/gnustep.scm (windowmaker)[arguments]: Add 'install-xsession'
>> phase.
>
> [...]
>
>> +               (call-with-output-file
>> +                   (string-append xsessions "/windowmaker.desktop")
>> +                 (lambda (port)
>> +                  (format port "~
>> +                    [Desktop Entry]~@
>> +                    Name=Window Maker~@
>> +                    Comment=~a~@
>> +                    Exec=~a/bin/wmaker~@
>> +                    Type=Application~%" ,synopsis %output))))
>
> We’ll have to make sure that ‘synopsis’ does not contain any newline
> character or the ‘.desktop’ file would have invalid syntax, I suppose.
>
> To be on the safe side perhaps we can do:
>
>   (string-map (match-lambda
>                 (#\newline #\space)
>                 (chr chr))
>               synopsis)
>
> Apart from that it LGTM, thanks!
>
> Ludo’.

Like I've attached?

Attachment: 0001-gnu-windowmaker-Add-.desktop-file.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]