[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29409] [PATCH] build: vm: Use qemu drive device parameter.
From: |
Ludovic Courtès |
Subject: |
[bug#29409] [PATCH] build: vm: Use qemu drive device parameter. |
Date: |
Fri, 08 Dec 2017 10:38:49 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
address@hidden skribis:
> From: Mathieu Othacehe <address@hidden>
>
> * gnu/build/vm.scm (load-in-linux-vm): As per network arguments, use device
> parameter to define drive device.
> ---
> gnu/build/vm.scm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm
> index 9e868f6..96c57ab 100644
> --- a/gnu/build/vm.scm
> +++ b/gnu/build/vm.scm
> @@ -126,10 +126,11 @@ the #:references-graphs parameter of 'derivation'."
> "-initrd" initrd
> "-append" (string-append "console=ttyS0 --load="
> builder)
> + "-device" "virtio-blk,drive=hd"
> (append
> (if make-disk-image?
> - `("-drive" ,(string-append "file=" output
> - ",if=virtio"))
> + `("-drive" ,(string-append "if=none,file=" output
> + ",id=hd"))
Is there a difference between ‘virtio’ and ‘virtio-blk’?
If confess I always have a hard time parsing QEMU’s command-line
options, but as long as it still works, it LGTM. :-)
Thanks,
Ludo’.