[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29359] [PATCH 21/31] gnu: Add java-xmlpull2.
From: |
Ricardo Wurmus |
Subject: |
[bug#29359] [PATCH 21/31] gnu: Add java-xmlpull2. |
Date: |
Sat, 16 Dec 2017 17:30:05 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
Hi Julien,
> * gnu/packages/java.scm (java-xmlpull2): New variable.
Please move this package to xml.scm.
[…]
> + (modify-phases %standard-phases
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((out (string-append (assoc-ref outputs "out")
> "/share/java")))
> + (mkdir-p out)
> + (copy-file "build/lib/PullParser-standard-2.1.10.jar"
> + (string-append out "/xmlpull2-standard.jar"))
> + (copy-file "build/lib/PullParser-2.1.10.jar"
> + (string-append out "/xmlpull2.jar")))
> + #t)))))
Could you use the “install-jars” procedure instead of this custom phase?
> + (home-page "http://www.extreme.indiana.edu/xgws/xsoap/xpp/")
> + (synopsis "Streaming pull XML parser")
> + (description "Xml Pull Parser (in short XPP) is a streaming pull
> XML
Please capitalize the first “Xml”.
> +parser and should be used when there is a need to process quickly and
> +efficiently all input elements (for example in SOAP processors).")
> + (license license:public-domain)))
The license does not seem to be correct. This is the license:
http://www.extreme.indiana.edu/xgws/xsoap/xpp/download/PullParser2/LICENSE.txt
It looks like a variant of the BSD-4 license, so non-copyleft would be
appropriate here. See also the Debian copyright file:
http://metadata.ftp-master.debian.org/changelogs/main/libx/libxpp2-java/libxpp2-java_2.1.10-7_copyright
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [bug#29359] [PATCH 21/31] gnu: Add java-xmlpull2.,
Ricardo Wurmus <=