[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>.
From: |
Ricardo Wurmus |
Subject: |
[bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>. |
Date: |
Sun, 17 Dec 2017 07:27:04 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
Hi,
> Patch 1 modifies gnu-build-system to explicitly check the return value of each
> phase for an unspecified value, and if found consider that phase to have
> failed.
>
> Patch 2 fixes several phases in gnu-build-system by making them return #t
> instead of an unspecified value.
>
> Patch 3 fixes the phases in several packages to return #t instead of an
> unspecified value. I was testing patch 1, by trying to build bash. In doing
> so, I found that the custom phases of many packages were not properly
> returning #t, and fixed all those packages. No doubt, there are many more
> packages that need fixing.
this is a step in the right direction. Thank you for these patches. In
my opinion, this can go straight to core-updates, but as it is a change
with wide-ranging consequences, I’d prefer for Ludovic to confirm that
it’s okay.
--
Ricardo
GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>., Arun Isaac, 2017/12/16
- [bug#29745] [PATCH 1/3] build: gnu-build-system: Disallow phase returning <unspecified>., Arun Isaac, 2017/12/16
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>.,
Ricardo Wurmus <=
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>., Ludovic Courtès, 2017/12/17
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>., Andreas Enge, 2017/12/18
- [bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>., Ricardo Wurmus, 2017/12/19
- bug#29745: [PATCH 0/3] Disallow phase returning <unspecified>., Arun Isaac, 2017/12/28
[bug#29745] [PATCH 0/3] Disallow phase returning <unspecified>., Marius Bakke, 2017/12/17