[bug#30013] [PATCH] gnu: Add vboot-reference.

[Ludovic Courtès]

Hi!

Marius Bakke <address@hidden> skribis:

> * gnu/packages/bootloaders.scm (vboot-reference): New public variable.

“vboot-utils”

> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'patch-hard-coded-paths
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (substitute* "futility/misc.c"
> +                        (("/bin/cp") (which "cp")))
> +                      (substitute* "tests/bitmaps/TestBmpBlock.py"
> +                        (("/usr/bin/cmp") (which "cmp")))

It would be better (though more verbose) to use:

  (string-append (assoc-ref inputs "coreutils") "/bin/cmp")

to allow for cross-compilation, though we’d also need to add coreutils
to ‘inputs’.  Not sure if it’s worth it, your call!

Otherwise LGTM.

Thanks,
Ludo’.