[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules.
From: |
Danny Milosavljevic |
Subject: |
[bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules. |
Date: |
Sun, 4 Mar 2018 13:45:04 +0100 |
Hi Ludo,
> (write-module-alias-database modules port) ;for “modules.alias”
> (write-module-device-database modules port) ;for “modules.devname”
I'd prefer "install-" because their interface is somewhat like install-file
(caller provides output directory and callee adds "modules."* automatically).
But I used the names "write-module-"* in the patchset v9.
> I’m not sure we need ‘install-module-files’ itself. Perhaps we can
> inline it at the call site?
Sure. Did so now.
> For the devname code, please avoid ‘set!’.
I found an even better way to avoid both.
> The indentation of ‘match’ forms is wrong. Would it be OK for you to
> pass it through ./etc/indent-code.el? (It’s non interactive, you don’t
> need to actually use Emacs.)
I'm actually trying to switch to emacs but when I press Tab it messes up
the stuff more. Is there some kind of configuration for guile indentation?
Also, every time I open gnu/build/linux-modules.scm I get
"The local variables list .. may not be safe
* bug-reference-bug-repexp
* eval: (modify-syntax-entry 126 "'")
* eval: (modify-syntax-entry 36 "'")
* eval: (modify-syntax-entry 43 "'")"
???
pgpK3sPwEsHIx.pgp
Description: OpenPGP digital signature
- [bug#30604] [PATCH v7 1/6] linux-modules: Add module-aliases., (continued)
- [bug#30604] [PATCH v7 1/6] linux-modules: Add module-aliases., Danny Milosavljevic, 2018/03/02
- [bug#30604] [PATCH v7 2/6] linux-modules: Add install-modules., Danny Milosavljevic, 2018/03/02
- [bug#30604] [PATCH v8 0/7] Load Linux module only when supported hardware is present., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 5/7] vm: Make the virtio-blk uniquely identifiable in /sys., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules., Ludovic Courtès, 2018/03/03
- [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules.,
Danny Milosavljevic <=
- [bug#30604] [PATCH v8 2/7] linux-modules: Add install-modules., Danny Milosavljevic, 2018/03/04
- [bug#30604] [PATCH v8 4/7] vm: Allow qemu-image builder to load Linux kernel modules., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 6/7] linux-initrd: Provide modprobe to the initrd., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 7/7] linux-initrd: Factorize %modprobe and flat-linux-module-directory., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 7/7] linux-initrd: Factorize %modprobe and flat-linux-module-directory., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 3/7] linux-boot: Load kernel modules only when the hardware is present., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 3/7] linux-boot: Load kernel modules only when the hardware is present., Ludovic Courtès, 2018/03/03
- [bug#30604] [PATCH v8 3/7] linux-boot: Load kernel modules only when the hardware is present., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 3/7] linux-boot: Load kernel modules only when the hardware is present., Danny Milosavljevic, 2018/03/03
- [bug#30604] [PATCH v8 3/7] linux-boot: Load kernel modules only when the hardware is present., Danny Milosavljevic, 2018/03/04