[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#30845] [PATCH 05/82] gnu: Add java-bouncycastle.
From: |
Björn Höfling |
Subject: |
[bug#30845] [PATCH 05/82] gnu: Add java-bouncycastle. |
Date: |
Mon, 19 Mar 2018 23:32:29 +0100 |
On Sun, 18 Mar 2018 14:05:25 +0100
Julien Lepiller <address@hidden> wrote:
> * gnu/packages/java.scm (java-bouncycastle): New variable.
> (java-bouncycastle-bcprov, java-bouncycastle-bcpkix): Remove variable.
> (java-kafka-clients): Use java-bouncycastle.
What's the difference between the old ones and the new one, besides of
the hosting site?
> ---
> gnu/packages/java.scm | 69
> ++++++++++++++++----------------------------------- 1 file changed,
> 21 insertions(+), 48 deletions(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index b1ecf843d..9f5b234bb 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -8229,29 +8229,37 @@ by technical operatives or consultants
> working with enterprise platforms.") algorithms and xxHash hashing
> algorithm.") (license license:asl2.0)))
>
> -(define-public java-bouncycastle-bcprov
> +(define-public java-bouncycastle
> (package
> - (name "java-bouncycastle-bcprov")
> + (name "java-bouncycastle")
> (version "1.58")
Upstream has 1.59 available that fixes a CVE. Can you use the newest
version, or do you need that specific one for Maven? If the latter is
the case, write a comment next to the version.
> (source (origin
> (method url-fetch)
> - (uri
> "https://bouncycastle.org/download/bcprov-jdk15on-158.tar.gz")
> + (uri (string-append
> "https://github.com/bcgit/bc-java/archive/r"
> + (substring version 0 1) "rv"
> + (substring version 2 4) ".tar.gz"))
> + ;(uri
> "https://bouncycastle.org/download/bcprov-jdk15on-158.tar.gz") (sha256
Old URI is kept as a comment. Is that by intention? Why?
> (base32
> -
> "1hgkg96llbvgs8i0krwz2n0j7wlg6jfnq8w8kg0cc899j0wfmf3n"))))
> + ;"1hgkg96llbvgs8i0krwz2n0j7wlg6jfnq8w8kg0cc899j0wfmf3n"))))
Same for the old hash. OK?
At least the 1.59 version contains two jars for the test:
bc-java-r1rv59$ find . -name "*.jar"
./test/libs/jna-4.3.0.jar
./test/libs/jna-platform-4.3.0.jar
Can you snip them away?
I tried to build it but it still hangs here:
[..]
test:
[mkdir] Created dir:
/tmp/guix-build-java-bouncycastle-1.58.drv-0/bc-java-r1rv58/build/jdk15on
[junit] Test org.bouncycastle.mail.smime.test.AllTests FAILED
Maybe it takes a bit longer and I know something tomorrow.
Final review in that series for me for tonight :-)
Thank you,
Björn
pgprg8l15SIGA.pgp
Description: OpenPGP digital signature
- [bug#30845] [PATCH 01/82] gnu: Add java-jline-2., (continued)
- [bug#30845] [PATCH 02/82] gnu: Update java-commons-cli to 1.4., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 06/82] gnu: Add java-commons-httpclient., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 07/82] gnu: Add java-commons-vfs., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 10/82] gnu: Add java-native-access-platform., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 05/82] gnu: Add java-bouncycastle., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 05/82] gnu: Add java-bouncycastle.,
Björn Höfling <=
- [bug#30845] [PATCH 03/82] gnu: java-eclipse-jetty-security-9.2: Ignore test error., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 04/82] gnu: Add java-commons-bsf., Julien Lepiller, 2018/03/18
- [bug#30845] [PATCH 09/82] gnu: Add java-native-access., Julien Lepiller, 2018/03/18