|
From: | Tobias Geerinckx-Rice |
Subject: | [bug#30889] [PATCH] gnu: Add pipewalker. |
Date: | Thu, 22 Mar 2018 00:47:07 +0100 |
User-agent: | Roundcube Webmail |
Ricardo, Thanks for the review! On 2018-03-22 0:22, Ricardo Wurmus wrote:
+ (uri (string-append "http://downloads.sourceforge.net/pipewalker/"+ name "-" version ".tar.gz"))Could you use the sourceforge mirror here?
I had some trouble with a dodgy mirror(?) when I wrote this, hence this ‘temporary’ workaround[0]. You're right that this should use a mirror.
+ (inputs + `(("libpng" ,libpng) + ("mesa" ,mesa) + ("sdl" ,sdl))) + (arguments + `(#:configure-flags + (list (string-append "--docdir=" (assoc-ref %outputs "out") + "/share/doc/" ,name "-" ,version)) + #:phases + (modify-phases %standard-phases + (add-after 'configure 'patch-docdir+ ;; Makefile.in ignores configure's ‘--docdir=...’ option. Fix that.+ (lambda _ + (substitute* "Makefile" + (("(pkgdocdatadir = ).*" _ key) + (string-append key "$(docdir)\n"))) + #t)))))It’s just a minor irritation for me, but I always expect to see the“arguments” field right below the build system field, because it definesarguments for the build system.
Hehe. We seem to have opposite irritations.I always expect the inputs to follow first, since they're, er, inputs, I guess, and often referenced later (;-) in arguments, together with things like source and outputs (doesn't the latter also belong at the end, then?). At least the inverse is never true.
Of course this is hardly a solid technical argument, if there is one. And the single example in the manual does list arguments before inputs.
Damn it.
+ (home-page "http://pipewalker.sourceforge.net/") + (synopsis "Logical tile puzzle") + (description+ "PipeWalker is a simple puzzle game with many diffent themes: connect all +computers to one network server, bring water from a source to the taps, etc. +The underlying mechanism is always the same: you must turn each tile in the +grid in the right direction to combine all components into a single circuit.+Every puzzle has a complete solution, although there may be more than one.")Sounds like fun!
It beats working. Kind regards, T G-R[0]: I'm aware that it still HTTP-redirects to a mirror. However, this worked.
Sent from a Web browser. Excuse or enjoy my brevity.
[Prev in Thread] | Current Thread | [Next in Thread] |