[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48.
From: |
Kei Kebreau |
Subject: |
[bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48. |
Date: |
Mon, 16 Apr 2018 23:32:23 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Marius Bakke <address@hidden> writes:
> Kei Kebreau <address@hidden> writes:
>
>> * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48.
>> [source]: Simplify snippet.
>> [build-system]: Switch to cmake-build-system.
>> [inputs]: Remove glu and mesa. Add libepoxy.
>> [arguments]: Remove modified phases.
>
> [...]
>
>> (modules '((guix build utils)))
>> (snippet
>> '(begin
>> ;; We don't need libretro for the GNU/Linux build.
>> - (delete-file-recursively "libretro")
>> - ;; Use system zlib.
>> - (delete-file-recursively "source/zlib")
>> - (substitute* "source/core/NstZlib.cpp"
>> - (("#include \"../zlib/zlib.h\"") "#include
>> <zlib.h>"))))))
>> - (build-system gnu-build-system)
>> + (delete-file-recursively "libretro")))))
>> + (build-system cmake-build-system)
>
> The commit message says 'simplify snippet', but the actual change is to
> not delete the zlib subfolder. Is zlib no longer bundled? If so,
> please mention that in the commit message.
>
> Apart from that LGTM.
Thank you for reviewing this!
I've attached a revised patch with some other small but necessary
changes that I overlooked the first time around. If the patch below
looks good, then I will push it to master.
0001-gnu-nestopia-ue-Update-to-1.48.patch
Description: Text document
signature.asc
Description: PGP signature