[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31178] [PATCH] gnu: Add inxi.
From: |
Oleg Pykhalov |
Subject: |
[bug#31178] [PATCH] gnu: Add inxi. |
Date: |
Mon, 23 Apr 2018 08:23:11 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Hello Pierre and Ludovic,
Pierre Neidhardt <address@hidden> writes:
> I didn't know Oleg was going to submit a patch, maybe there was some
> confusion in the process :p
I've mentioned it in our mailing list discussion, see
https://lists.gnu.org/archive/html/help-guix/2018-04/msg00130.html
Nevertheless thank you for a 31178! :-)
> I've quickly reviewed our two patches. Overall I'd opt for mine :p
>
> - It's the latest version.
> - It has more inputs.
I thought that we stuck with an ‘inxi’ Perl script version (31178) and
there was no patch until I pushed one. It's better to get 31178 version
than 31176 ofcourse because of ‘inxi’ version.
But I don't like all those ‘propagated-inputs’ except ‘perl-*’ and I
guess we could do better. Maybe we could use PATH for non ‘perl-*’
inputs the same way as in 31176. WDYT?
> I think we should use propagated-inputs and not native-inputs. What do
> you think?
I'm not sure about 31178 currently. Usually we prefer to avoid
‘propagated-inputs’ if possible in Guix, because all ‘propagated-inputs’
will be in a Guix profile and could lead to collisions.
If you are talking about 31176, then no, because I've used a wrapper to
find all ‘inxi-minimal’ or ‘inxi’ requisites. It was easy to do,
because ‘inxi’ in 31176 is a Shell script, not a Perl script. Thanks to
Chris Marusich for an idea.
[…]
[1] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=31176
Oleg.
signature.asc
Description: PGP signature
- [bug#31178] [PATCH] gnu: Add inxi., Pierre Neidhardt, 2018/04/16
- [bug#31176] [bug#31178] [PATCH] gnu: Add inxi., Ludovic Courtès, 2018/04/22
- [bug#31178] [PATCH] gnu: Add inxi., Pierre Neidhardt, 2018/04/23
- [bug#31178] [PATCH] gnu: Add inxi.,
Oleg Pykhalov <=
- [bug#31178] [PATCH] gnu: Add inxi., Pierre Neidhardt, 2018/04/23
- [bug#31176] [bug#31178] [PATCH] gnu: Add inxi., Ludovic Courtès, 2018/04/28
- [bug#31176] [bug#31178] [PATCH] gnu: Add inxi., Oleg Pykhalov, 2018/04/29
- [bug#31178] [PATCH] gnu: Add inxi., Ludovic Courtès, 2018/04/30
- [bug#31176] [bug#31178] [PATCH] gnu: Add inxi., Pierre Neidhardt, 2018/04/30
- [bug#31176] [bug#31178] [PATCH] gnu: Add inxi., Oleg Pykhalov, 2018/04/30
[bug#31178] [PATCH] gnu: Add inxi., Tobias Geerinckx-Rice, 2018/04/30