[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31102] [PATCH] gnu: wpa-supplicant: Install wpa_gui.
From: |
Ludovic Courtès |
Subject: |
[bug#31102] [PATCH] gnu: wpa-supplicant: Install wpa_gui. |
Date: |
Thu, 26 Apr 2018 00:11:40 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Howdy Marius,
Marius Bakke <address@hidden> skribis:
> Ludovic Courtès <address@hidden> writes:
>
>> Hi Marius,
>>
>> Marius Bakke <address@hidden> skribis:
>>
>>> * gnu/packages/admin.scm (wpa-supplicant)[inputs]: Add QTBASE and QTSVG.
>>> [native-inputs]: Add IMAGEMAGICK and INKSCAPE.
>>> [outputs]: New field.
>>> [arguments]: Add phases 'build-wpa-gui' and 'install-wpa-gui'.
>>
>> The patch LGTM, but I wonder if we should make it a separate package.
>>
>> Since it uses a separate output, that should be fine *if* you get
>> substitutes. If you don’t, then you end up building Qt.
>>
>> Since wpa_supplicant is a requirement for most GuixSD configs, that
>> could be an issue.
>>
>> From the patch, it seems that the GUI is well isolated, in a separate
>> directory, with a different build system and all. Do you think it would
>> work to make a separate “wpa-supplicant-gui” package? WDYT?
>
> Yes, that makes sense. I pushed it as a separate package in
> 050e5756781cdfed2d790e15c67bc48c9aced131.
Awesome, thank you!
Ludo’.