[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31237: [PATCH] gnu: Add runc.
From: |
宋文武 |
Subject: |
bug#31237: [PATCH] gnu: Add runc. |
Date: |
Thu, 26 Apr 2018 09:39:58 +0800 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hello,
>
> address@hidden (宋文武) skribis:
>
>> No I haven't, some fails are:
>>
>> --- FAIL: TestFactoryNewTmpfs (0.00s)
>> factory_linux_test.go:87: operation not permitted
>>
>> FAIL github.com/opencontainers/runc/libcontainer 0.047s
>> ? github.com/opencontainers/runc/libcontainer/apparmor [no test files]
>>
>> --- FAIL: TestInvalidCgroupPath (0.00s)
>> apply_raw_test.go:16: couldn't get cgroup root: mountpoint for
>> cgroup not found
>> apply_raw_test.go:25: couldn't get cgroup data: mountpoint for
>> cgroup not found
>> panic: runtime error: invalid memory address or nil pointer dereference
>> [recovered]
>>
>> --- FAIL: TestValidateRootlessMountUid (0.00s)
>> rootless_test.go:96: Expected error to not occur when uid= not
>> set in mount options: rootfs (/var) does not exist
>> rootless_test.go:106: Expected error to not occur when setting
>> uid=0 in mount options: rootfs (/var) does not exist
>> rootless_test.go:112: Expected error to not occur when setting
>> uid=2 in mount options and UidMapping[0].size is 10
>>
>> --- FAIL: TestValidateValidSysctl (0.00s)
>> validator_test.go:229: Expected error to not occur with
>> {net.ctl=ctl} but got: "rootfs (/var) does not exist"
>> validator_test.go:229: Expected error to not occur with
>> {kernel.msgmax=ctl} but got: "rootfs (/var) does not exist"
>> validator_test.go:229: Expected error to not occur with
>> {fs.mqueue.ctl=ctl} but got: "rootfs (/var) does not exist"
>>
>> --- FAIL: TestNsenterValidPaths (0.01s)
>> nsenter_test.go:65: nsenter exits with a non-zero exit status
>>
>>
>> Look like it need /var, network namespace and other things? But thoes
>> are unittest (runc also has integrationtest target)... Need more
>> investment.
>
> Right. For now I think we could skip all the tests above, with a
> comment explaining the reason (/var, cgroups, and apparmor unavailable
> in the build environment.)
>
Done, thank you!