[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31252: [PATCH] gnu: Add Ranger.
From: |
Eric Bavier |
Subject: |
bug#31252: [PATCH] gnu: Add Ranger. |
Date: |
Thu, 26 Apr 2018 21:11:13 -0500 |
On Wed, 25 Apr 2018 23:09:39 +0200
address@hidden (Ludovic Courtès) wrote:
> Eric Bavier <address@hidden> skribis:
>
> > + (arguments
> > + '(#:phases (modify-phases %standard-phases
> > + (replace 'check
> > + (lambda _ (invoke "make" "test"))))))
>
> You can use #:test-target "test" instead.
>
> > + (home-page "https://ranger.github.io/")
> > + (synopsis "Console file manager")
> > + (description "@code{ranger} is a console file manager with VI key
>
> Nitpick: “Ranger” (or “ranger”?) and “Vi”.
>
> I haven’t tried using it, but otherwise LGTM. Thanks!
Thanks for the review.
Pushed in 834b0b9a5ca7ebd2cd3c1b2fe8dcb99e5e2f0841 and
adfc742c420f34ecf925ea00d49204f9863bce33 (forgot to apply fixes before pushing
... oops).
`~Eric
pgpdFa0e1a8y4.pgp
Description: OpenPGP digital signature