[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#31490: [PATCH] gnu: Add emacs-cmake-mode.
|
From: |
Oleg Pykhalov |
|
Subject: |
bug#31490: [PATCH] gnu: Add emacs-cmake-mode. |
|
Date: |
Tue, 22 May 2018 17:25:43 +0300 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) |
Maxim Cournoyer <address@hidden> writes:
[…]
>> + (substitute* "Auxiliary/CMakeLists.txt"
>> + (("install\\(FILES cmake-mode.el \
>> +DESTINATION \\$\\{CMAKE_DATA_DIR\\}/editors/emacs\\)") ""))))
>
> Nitpick: I'd use a regexp to match the text following cmake-mode.el on
> the line to make it more resilient to any future changes. Otherwise this
> LGTM :)
Agree, pushed as f037673c3133ae7453794f1f62eecebf9d06b092
and emacs-cmake-mode bbdf36666b82eae0a583d7124d8117801969570c
Oleg.
signature.asc
Description: PGP signature