[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31399] [PATCH] import: elpa: Implement recursive import.
From: |
Ricardo Wurmus |
Subject: |
[bug#31399] [PATCH] import: elpa: Implement recursive import. |
Date: |
Fri, 8 Jun 2018 14:59:59 +0200 |
User-agent: |
mu4e 1.0; emacs 25.3.1 |
Hi Oleg,
>> I’d find it clearer to have a first patch that moves code from cran.scm
>> to utils.scm, and a second patch containing the ELPA changes. No big
>> deal though.
>
> OK, splitted the patch. Also removed unused srfi-41.
>
>> Please double-check that tests/{elpa,cran}.scm still pass, but if they
>> do, I think you can go ahead and push.
>
> I tested both commits separately. Pushed as:
>
> - 74032da3a2ef3e99e89dd58701414004f5a6c061
> - ae9e5d6602544390fa5da0a87450405ebba012fd
Thank you!
> While I've tested, ‘test-tmp/db/’ directory was missing in my Guix Git
> repository (‘test-tmp’ directory was present), tests failed until I
> manually created by invoking ‘mkdir test-tmp/db’. I've tried to remove
> ‘test-tmp’, invoke ‘./configure --localstatedir=/var --prefix=’ and
> ‘make’, but it produced only ‘test-tmp’ directory.
This seems to be a problem that was introduced with commit
7f9d184d9b688d13ce76eefabaddcfa76bdde2b5.
--
Ricardo