guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#31687] [PATCH] services: Add dnsmasq-service-type.


From: Ludovic Courtès
Subject: [bug#31687] [PATCH] services: Add dnsmasq-service-type.
Date: Fri, 08 Jun 2018 16:43:40 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello!

Thanks for this patch, that looks like a useful service to have!

宋文武 <address@hidden> skribis:

> address@hidden @code{no-negcache?} (default: @code{#f})
> +When true, disable negative caching.

Minor issues:

  • The general guideline is to avoid abbreviations in identifiers—we’re
    using the language that comes with ‘call-with-current-continuation’,
    after all.  ;-)

  • Another guideline is to avoid double-negations and the likes.

So in this example, I would recommend:

  ‘negative-caching?’ (default: #t)

I think there’s a couple of other abbreviations.

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]