[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#31957] [PATCH] gnu: Add python-libusb1.
From: |
Marius Bakke |
Subject: |
[bug#31957] [PATCH] gnu: Add python-libusb1. |
Date: |
Mon, 25 Jun 2018 21:46:27 +0200 |
User-agent: |
Notmuch/0.27 (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) |
Vagrant Cascadian <address@hidden> writes:
> Add new package definition for python-libusb1, needed to upgrade
> python-trezor to newer versions.
Thanks! I have some minor nitpicks:
[...]
> * gnu/packages/libusb.scm (python-libusb1): New variable.
Can you also add yourself to the copyright header in this file?
[...]
> +(define-public python-libusb1
> + (package
> + (name "python-libusb1")
> + (version "1.6.4")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "libusb1" version))
> + (sha256
> + (base32
> + "03b7xrz8vqg8w0za5r503jhcmbd1ls5610jcja1rqz833nf0v4wc"))))
> + (build-system python-build-system)
> + (arguments
> + `(#:modules ((srfi srfi-1)
> + (srfi srfi-26)
Is srfi-26 actually used here?
> + (guix build utils)
> + (guix build python-build-system))
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'fix-libusb-reference
> + (lambda* (#:key inputs #:allow-other-keys)
> + (substitute* "usb1/libusb1.py"
> + (("libusb_path = ctypes.util.find_library\\(base_name\\)")
> + (string-append
> + "libusb_path = \""
> + (find (negate symbolic-link?)
> + (find-files (assoc-ref inputs "libusb")
> + "^libusb.*\\.so\\..*"))
> + "\"")))
> + #t)))))
> + (inputs `(("libusb" ,libusb)))
> + (home-page
> + "http://github.com/vpelletier/python-libusb1")
This line break is unnecessary :-)
> + (synopsis "Pure-python wrapper for libusb-1.0")
> + (description
> + "Pure-python wrapper for libusb-1.0")
This description is rather thin. Can you try to make it into one or
more full sentences?
> + (license lgpl2.1+)))
I noticed the source contains GPL2 in COPYING, and LGPL2.1 as
"COPYING.LESSER". Can you make sure we don't install the former?
Can you send an updated patch? Thanks in advance!
signature.asc
Description: PGP signature