guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#32768] [PATCH] gnu: go-1.11: Add New Version


From: Leo Famulari
Subject: [bug#32768] [PATCH] gnu: go-1.11: Add New Version
Date: Wed, 19 Sep 2018 17:20:32 -0400
User-agent: Mutt/1.10.1 (2018-07-13)

On Tue, Sep 18, 2018 at 09:52:58PM -0500, Katherine Cox-Buday wrote:
> +(define-public go-1.11

Thanks!

I tested that some basic packages build within the go-build-system using
Go 1.11 (several need to be updated to support Go 1.11, however).

> +                             ;; A side affect of these test scripts is 
> testing
> +                             ;; cgo. Attempts at using cgo flags and
> +                             ;; directives with these scripts as specified
> +                             ;; here (https://golang.org/cmd/cgo/) have not
> +                             ;; worked. The tests continue to state that they
> +                             ;; can not find crt1.o despite being present.
> +                             
> "cmd/go/testdata/script/list_compiled_imports.txt"
> +                             "cmd/go/testdata/script/mod_case_cgo.txt"
> +                             ;; https://github.com/golang/go/issues/24884
> +                             "os/user/user_test.go"))

Okay, we can punt on this for now.

> +           (replace 'set-bootstrap-variables
> +             (lambda* (#:key outputs inputs #:allow-other-keys)
> +               ;; Tell the build system where to find the bootstrap Go.
> +               (let ((go  (assoc-ref inputs "go")))
> +                 (setenv "GOROOT_BOOTSTRAP" go)
> +                 (setenv "GOGC" "400")
> +                 ;; Go 1.10 tries to write to $HOME in a test
> +                 (setenv "HOME" "/tmp")
> +                 #t)))))))))

This phase is identical to the one that would be inherited from Go 1.10,
right?

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]