bug#32785: [PATCH] services: wpa-supplicant: Extend to support configuration parameters.

[Marius Bakke]

address@hidden (Ludovic Courtès) writes:

> Hello,
>
> Marius Bakke <address@hidden> skribis:
>
>> This allows using WPA Supplicant "standalone" without an additional
>> network manager.  The default configuration is unchanged.
>>
>> * gnu/services/networking.scm (<wpa-supplicant-configuration>): New record 
>> type.
>> (wpa-supplicant-shepherd-service): Pass configuration records to the daemon.
>> (wpa-supplicant-service-type): Adjust accordingly.
>> * doc/guix.texi (Networking Services): Document the new service type.
>
> [...]
>
>> address@hidden {Data Type} wpa-supplicant-manager-configuration
>                                      ^
> Should be ‘wpa-supplicant-configuration’.

Good catch; fixed!

>
>> +    (service-type (name 'wpa-supplicant)
>> +                  (extensions
>> +                   (list (service-extension shepherd-root-service-type
>> +                                            wpa-supplicant-shepherd-service)
>> +                         (service-extension dbus-root-service-type 
>> config->package)
>> +                         (service-extension profile-service-type 
>> config->package)))
>> +                  (default-value (wpa-supplicant-configuration)))))
>
> While you’re at it you can add a ‘description’ field.  :-)

See previous comment.

> I haven’t tested it but it LGTM.

I have done some testing and the default configuration seems to work
as before.  Pushed as acce0a474c1493ab18912bc46285248e4ccb0314.

Thank you!

signature.asc
Description: PGP signature