[bug#33099] [PATCH] I add r-aspi package appended to cran.scm file

[Ricardo Wurmus]

Hi Laura,

congratulations on your first patch to Guix!

What follows are a few comments on minor changes that I would like to
see before applying the patch to Guix.

> From 132c8bf1e57f30485e3701ce01ea9d1ac7207e7c Mon Sep 17 00:00:00 2001
> From: laura <address@hidden>
> Date: Fri, 19 Oct 2018 19:15:37 -0300
> Subject: [PATCH] I add r-aspi package appended to cran.scm file
>
> ---
>  gnu/packages/cran.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

For commits to Guix, we use a somewhat strict commit message format.
You can take a look at the commit log to get a feel for it.  In the case
of adding r-aspi to cran.scm this would be the expected commit message:

--8<---------------cut here---------------start------------->8---
gnu: Add r-aspi.

* gnu/packages/cran.scm (r-aspi): New variable.
--8<---------------cut here---------------end--------------->8---

The first line is always a concise summary.  This is followed by a
change log listing modified files and how they were modified.

> diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
> index efcc2dccb..0d8ee6a97 100644
> --- a/gnu/packages/cran.scm
> +++ b/gnu/packages/cran.scm
> @@ -6256,3 +6256,22 @@ a header row or not.  The dataset should contain
> only one independent variable
>  (x) and one dependent variable (y) and can contain a weight for each
>  observation.")
>      (license license:gpl2)))
> +
> +(define-public r-aspi
> +  (package
> +    (name "r-aspi")
> +    (version "0.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (cran-uri "aspi" version))
> +       (sha256
> +        (base32
> +         "0rhvxw243vvdv3hxa6pi343gcjc2cbxq1jzqirl9k1l4i3897l87"))))
> +    (build-system r-build-system)
> +    (home-page "https://cran.r-project.org/web/packages/aspi/";)
> +    (synopsis "Analysis of Symmetry of Parasitic Infections")

Please use lowercase for all words except for the first.  CRAN synopses
are usually in titlecase and the importer can’t automatically figure out
which words should be converted, so this needs to be done manually.

> +    (description
> +     "Tools for the analysis and visualization of bilateral asymmetry in
> + parasitic infections.")

Please use a complete sentence for the description.  The easiest way is
probably to just prepend “This package provides”.

> +    (license license:gpl3)))

I checked the source files and noticed that it’s actually GPL 3 or
later.  Here’s an except from the header of aspi.R:

--8<---------------cut here---------------start------------->8---
#  Analysis of Symmetry of Parasitic Infections is free software: you can       
 #
#  redistribute it and/or modify it under the terms of the GNU General Public   
 #
#  License as published by the Free Software Foundation, either version 3 of    
 #
#  the License, or (at your option) any later version.                          
 #
--8<---------------cut here---------------end--------------->8---

So this really should be “license:gpl3+”.

(I haven’t tried building the package yet.)

I think it’s fine to apply the patch with these minor changes.

--
Ricardo