guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#33059] [PATCH 04/10] gnu: Add python-fenics-dijitso.


From: Ludovic Courtès
Subject: [bug#33059] [PATCH 04/10] gnu: Add python-fenics-dijitso.
Date: Wed, 24 Oct 2018 23:48:07 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Paul Garlick <address@hidden> skribis:

> * gnu/packages/simulation.scm (python-fenics-dijitso): New varaible.

I agree with Efraim’s suggestion to use ‘with-directory-excursion’.

Nitpick:

> +      (home-page
> +      "https://bitbucket.org/fenics-project/dijitso/";)

Indentation is off.

> +    (synopsis
> +      "Distributed just-in-time building of shared libraries")

Please keep ‘home-page’ and ‘synopsis’ on a single line each.

Otherwise LGTM, thanks!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]