[bug#33334] [PATCH]:gnu:add ne:the nice editor

[swedebugia]

Hi :)
Did you run ./pre-inst-env guix lint on the package?
It has trailing whitespaces in two places.

On 2018-11-10 10:25, guy fleury wrote:
> hi all,
>
> i have packaged: ne "the nice editor".
> it is my first tempt to contribute to any project,if i do things wrong
> tell me with additionnal informations!

Thank you! Me too. I submitted my first patch ever to Guix a few days 
ago. :)

> 0001-gnu-add-ne-the-nice-editor.patch
>
>  From 1ec45eaa225e7203a98b36cddb7d42db418b773b Mon Sep 17 00:00:00 2001
> From: guy fleury<address@hidden>
> Date: Sat, 10 Nov 2018 10:51:17 +0200
> Subject: [PATCH] gnu:add ne:the nice editor

snip

> +    (build-system gnu-build-system)
> +    (arguments
> +       `(#:tests? #f

Could you please explain why the tests are disabled?
Search the packages to see examples of explanations.

> +          #:make-flags (list (string-append "PREFIX=" (assoc-ref %outputs 
> "out"))
> +                   "CC=gcc")
> +         #:parallel-build? #f
> +         #:phases (modify-phases %standard-phases
> +                                 (delete 'configure))))

Same here. Please explain.

Tested the compilation and ran the editor. Seemed nice!

Maybe this could complement nano if it highlights scheme and has a macro 
to help with e.g. finding missing parens.

Could you send an updated patch?

--
Cheers
Swedebugia