guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#33572: [PATCH] Make Guile-JSON a required dependency.


From: Eric Bavier
Subject: bug#33572: [PATCH] Make Guile-JSON a required dependency.
Date: Sun, 2 Dec 2018 18:22:18 -0600

On Sun, 02 Dec 2018 23:39:04 +0100
address@hidden (Ludovic Courtès) wrote:

> Hello Eric,
> 
> address@hidden skribis:
> 
> > From: Eric Bavier <address@hidden>
> >
> > * README (Requirements): Remove "optional" verbiage.
> > * configure.ac (HAVE_GUILE_JSON): Remove Automake conditional.
> > (have_guile_json): Error if not "yes".
> > * Makefile.am (MODULE, SCM_TESTS)[HAVE_GUILE_JSON]: Add modules and tests
> > unconditionally.
> > * gnu/packages/package-mangement.scm (guix-minimal)[propagated-inputs]: 
> > Leave
> > guile-json input.  
> 
> Could you include guix.texi changes along the lines of what Joshua
> proposed on guix-devel?

Done.

> Otherwise LGTM, thanks!
> 
> Ludo’.

Thanks for the review.  Pushed
in 6776af04d4b65c5a9a07784307a6abe395b6f480

`~Eric

Attachment: pgptjIk88qdTg.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]