guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#33801] import: github: Support source URIs that redirect to GitHub


From: Ludovic Courtès
Subject: [bug#33801] import: github: Support source URIs that redirect to GitHub
Date: Fri, 21 Dec 2018 16:18:27 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux)

Hello!

Arun Isaac <address@hidden> skribis:

> From 65c540c549c1f2a415b54ccc04dec4b1406bb5eb Mon Sep 17 00:00:00 2001
> From: Arun Isaac <address@hidden>
> Date: Fri, 21 Dec 2018 17:48:55 +0530
> Subject: [PATCH] guix: lint: Check for source URIs redirecting to GitHub.
>
> * guix/scripts/lint.scm (check-github-uri): New procedure.
> (%checkers): Add it.

Overall LGTM.  Two things:

  1. Could you add tests in tests/lint.scm?  You can use the same
     strategy as the the ‘source’ tests there.  Let me know if you have
     questions.

  2. Could you add it to doc/guix.texi?

Thank you!

Ludo’.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]