[bug#33849] [PATCH] gnu: Add polybar

[Ludovic Courtès]

Hello,

Meiyo Peng <address@hidden> skribis:

>>From e5871eaba91a1d5909fbc0ffcea767244204f644 Mon Sep 17 00:00:00 2001
> From: Meiyo Peng <address@hidden>
> Date: Sun, 23 Dec 2018 23:05:38 +0800
> Subject: [PATCH] gnu: Add polybar.
>
> * gnu/packages/wm.scm (polybar): New variable.

[...]

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/jaagr/polybar/releases/";
> +                           "download/" version "/polybar.tar"))
> +       (sha256
> +        (base32 "1zpsvh1n77bx7s6mqqh3ba828k9xbp35c2mjmcl9nywfp6r5ldqi"))
> +       (file-name (string-append name "-" version ".tar"))))

Please use ‘git-fetch’ rather than downloading a generated tarball (it’s
a generated tarball, right?).

> +    (build-system cmake-build-system)
> +    (arguments
> +     ;; Test is disabled because it requires downloading googletest from the
> +     ;; Internet.
> +     '(#:tests? #f))

Did you try adding ‘googletest’ to ‘native-inputs’, and perhaps also
disabling the code that tries to download it?

The rest LGTM!  Could you send an updated patch?

Thank you,
Ludo’.