[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#33875: [PATCH] `guix lint' warn of GitHub autogenerated source tarba
From: |
Efraim Flashner |
Subject: |
bug#33875: [PATCH] `guix lint' warn of GitHub autogenerated source tarballs |
Date: |
Thu, 27 Dec 2018 14:58:22 +0200 |
User-agent: |
Mutt/1.11.0 (2018-11-25) |
On Wed, Dec 26, 2018 at 06:40:22PM +0100, Ludovic Courtès wrote:
> Hello!
>
> Efraim Flashner <address@hidden> skribis:
>
> > From dcd8b207f932289cb3b35720af45f49f849b7c27 Mon Sep 17 00:00:00 2001
> > From: Efraim Flashner <address@hidden>
> > Date: Tue, 25 Dec 2018 16:29:12 +0200
> > Subject: [PATCH] lint: Add checker for unstable tarballs.
> >
> > * guix/scripts/lint.scm (check-source-unstable-tarball): New procedure.
> > (%checkers): Add it.
> > * tests/lint.scm ("source-unstable-tarball", "source-unstable-tarball:
> > source #f", "source-unstable-tarball: valid", "source-unstable-tarball:
> > package named archive", "source-unstable-tarball: not-github",
> > "source-unstable-tarball: git-fetch"): New tests.
>
> Could you mention ‘source-unstable-tarball’ in doc/guix.texi?
Added
>
> Otherwise LGTM!
>
> Please double-check that “make check TESTS=tests/lint.scm” passes and
> that ‘./pre-inst-env guix lint -c source-unstable-tarball’ works.
‘./pre-inst-env guix lint -c source-unstable-tarball’ shows many many
autogenerated tarballs, and I made the checks pass.
>
> Thanks!
>
> Ludo’.
Pushed as c180017b6f7e9b6d23238c1fbaac986c435cd35e
--
Efraim Flashner <address@hidden> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature