[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug#34175] [PATCH 4/4] gnu: Add efilinux.
From: |
Ricardo Wurmus |
Subject: |
[bug#34175] [PATCH 4/4] gnu: Add efilinux. |
Date: |
Wed, 23 Jan 2019 09:12:08 +0100 |
User-agent: |
mu4e 1.0; emacs 26.1 |
Danny Milosavljevic <address@hidden> writes:
> * gnu/packages/efi.scm (efilinux): New variable.
[…]
> + (arguments
> + `(#:make-flags
> + (list "CC=gcc"
> + (string-append "INCDIR=" (assoc-ref %build-inputs "gnu-efi")
> + "/include")
> + (string-append "LIBDIR=" (assoc-ref %build-inputs "gnu-efi")
> + "/lib"))
Nitpick: I’d use a let binding for (assoc-ref %build-inputs "gnu-efi").
> + #:tests? #f ; No tests exist.
> + #:phases
> + (modify-phases %standard-phases
> + (delete 'configure)
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (install-file "efilinux.efi"
> + (string-append (assoc-ref outputs "out")
> + "/libexec"))
The indentation of "/libexec" is off.
Otherwise LGTM.
--
Ricardo