guix-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[bug#34538] [PATCH] gnu: Add r-sloop.


From: Ricardo Wurmus
Subject: [bug#34538] [PATCH] gnu: Add r-sloop.
Date: Wed, 20 Feb 2019 17:47:48 +0100
User-agent: mu4e 1.0; emacs 26.1

Hi Brett,

> * gnu/packages/cran.scm (r-sloop): New variable.
[…]
> +
> +(define-public r-sloop
> +  (package
> +  (name "r-sloop")
> +  (version "1.0.1")
> +  (source
> +    (origin
> +      (method url-fetch)
> +      (uri (cran-uri "sloop" version))
> +      (sha256
> +        (base32
> +          "00fk5fr5zsk2qxc1kfhmshhjxgnamm3401089sx8m2l529zd6r8j"))))
> +  (build-system r-build-system)
> +  (propagated-inputs
> +    `(("r-codetools" ,r-codetools)
> +      ("r-crayon" ,r-crayon)
> +      ("r-purrr" ,r-purrr)
> +      ("r-rlang" ,r-rlang)
> +      ("r-tibble" ,r-tibble)))
> +  (home-page "https://github.com/r-lib/sloop";)
> +  (synopsis "Helpers for 'OOP' in R")
> +  (description
> +    "This package provides a collection of helper functions designed to help 
> you to better understand object oriented programming in R, particularly using 
> 'S3'.")
> +  (license license:gpl3)))

There are a couple of problems here:

- The indentation is wrong throughout.
- Please don’t use “'” in the synopsis and description.
- Please spell out “OOP” in the synopsis
- Please break the long description up into several lines.  “guix lint”
  will warn you about this, so please use it.

Could you please send a new patch to address@hidden

Thanks!

--
Ricardo






reply via email to

[Prev in Thread] Current Thread [Next in Thread]